search

Rantanen / node-mumble

Mumble client in Node.js
MIT License
155 stars 48 forks source link

Add method to register another user #105

Closed Prior99 closed 6 years ago

Prior99 commented 6 years ago

Will close #109.

Prior99 commented 6 years ago

@Rantanen I am somewhat confused by the codacy bot. I saw singlequotes basically all over the project. Should I address all of these issues? I believe the Travis is failing since a long time. Also, the user_id of course needs to be snake_case as it's a mumble internal field.

Prior99 commented 6 years ago

@Rantanen, hey, do you need anything else to be done on this branch? Otherwise I'd really appreciate a merge and a release :)

Rantanen commented 6 years ago

I needed a reminder. :)

Rantanen commented 6 years ago

The merge is now published as version 0.3.14. Thanks for the PR!