search

Rantanen / node-mumble

Mumble client in Node.js
MIT License
155 stars 48 forks source link

Keep _users in sync with the actual users on the server. #117

Closed Aubron closed 5 years ago

Aubron commented 5 years ago

Fixes #70

Rather naive PR, interested in feedback from maintainer(s)

codecov-io commented 5 years ago

Codecov Report

Merging #117 into master will decrease coverage by 0.11%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
- Coverage   20.99%   20.88%   -0.12%     
==========================================
  Files          12       12              
  Lines        1124     1130       +6     
  Branches      185      186       +1     
==========================================
  Hits          236      236              
- Misses        888      894       +6
Impacted Files Coverage Δ
lib/MumbleClient.js 20.46% <0%> (-0.75%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 62a2e3f...acf859e. Read the comment docs.

Aubron commented 5 years ago

@Rantanen - Fixed linting problems, but tests are gonna keep failing due to the mumble server being offline.

Aubron commented 5 years ago

@Rantanen - updates made, let me know what you think!

Rantanen commented 5 years ago

Pushed version 0.3.20 to npm

Aubron commented 5 years ago

Thanks! :shipit: 🎉