search

Rantanen / node-mumble

Mumble client in Node.js
MIT License
155 stars 48 forks source link

Use a more conservative estimate of overhead #118

Closed brooksmckinley closed 5 years ago

brooksmckinley commented 5 years ago

The previous estimate based on the mumble client settings frequently caused skipping when trying to transmit audio. In order to prevent this, this commit makes the overhead estimate higher so the client will use a lower bitrate.

From my testing, a nodejs client with the bitrate set to 128,000 reached up to 165,400. To get to the overhead estimate I used here, I rounded 165,400 up to 170,000 to be safe, and subtracted 128,000.

This should fix https://github.com/Rantanen/node-mumble/issues/59

Rantanen commented 5 years ago

Thanks! If this fixed the issue for you, that's good enough for me in this case.

Rantanen commented 5 years ago

Published the change in version 0.3.21