Rantanen / node-mumble

Mumble client in Node.js
MIT License
155 stars 48 forks source link

check server connections #123

Closed far0ouk closed 3 years ago

far0ouk commented 3 years ago

if server offline check connection every 5 sec

Rantanen commented 3 years ago

Few comments on an initial glance:

On function naming

The disconnect-detection should be built into the MumbleConnection class, which already has an interval for ping implementation, the same interval should be used for detecting dead sockets. That interval is handled properly in regards to closing the connection.