search

Rantanen / node-mumble

Mumble client in Node.js
MIT License
155 stars 48 forks source link

opus support? #3

Closed jamon closed 9 years ago

jamon commented 10 years ago

I'm not sure how different the libopus library is from libcelt, and not sure how difficult it'd be to build a node-opus. Unfortunately I don't have the background to really contribute much to this, short of testing and Node.JS side code, but I at least wanted to express my interest, in case you had free time and interest in updating :)

Thanks!

Rantanen commented 9 years ago

I would imagine it's not too difficult to use and given opus is part of WebRTC a node-opus library will happen sooner or later. I'm finally back from a year-long government commitment and picking these projects up.

Currently trying to get Rantanen/node-peerconnection working again for WebRTC. Given this will require opus encoding at some point, I'll probably get around to it then.

Prior99 commented 9 years ago

Bump! Opus support would be a big plus. Maybe you can take a look at it using your own node-opus @Rantanen ? If you don't have the time or are to busy I could also take a look at this but I guess you could do it better and faster.

Rantanen commented 9 years ago

Planned on taking a look at it this evening once I finish my real work for the day.

Rantanen commented 9 years ago

Implemented in 47a6be94fddb97d13b831ec18505e13010b62f25

Thanks to @Prior99 for starting the work!