search

Rantanen / node-mumble

Mumble client in Node.js
MIT License
155 stars 48 forks source link

Propagate permission denied errors #47

Closed justinmchase closed 9 years ago

justinmchase commented 9 years ago

Simply emit an event when this occurs.

justinmchase commented 9 years ago

I will elaborate on this in the morning based the feedback from the other PR and fix the lint error as well.

Rantanen commented 9 years ago

Check the last changes in the repository. Lint errors are fixed and an error event implemented. However I'd like to hear opinions on whether throwing the error if no error event handlers are found is a good idea or not.

justinmchase commented 9 years ago

Ah, looks good to me!