Rantanen / node-mumble

Mumble client in Node.js
MIT License
155 stars 48 forks source link

The default value for temporary should be true #48

Closed justinmchase closed 9 years ago

justinmchase commented 9 years ago

I was hitting an error where creating a subchannel was firing a permission denied error. It seems like creating a permanent channel is much more likely to hit this and also should require more intent on the part of the developer. Thus I think that the default for adding subchannels should be temporary: true.

Rantanen commented 9 years ago

Not really sure I agree with this for two reasons:

How about we expand your "permission-denied" event propagation by propagating all errors with the traditional 'error' event with the caveat that if this event isn't handled (or ignored with client.on( 'error', function(){});) then the errors are thrown with throw which will bring these to the developer's attention?

justinmchase commented 9 years ago

ok.