search

Rantanen / node-mumble

Mumble client in Node.js
MIT License
155 stars 48 forks source link

Add User.kick/ban #61

Closed tjhorner closed 9 years ago

tjhorner commented 9 years ago

Allows bots to kick users, useful for moderating chat.

tjhorner commented 9 years ago

Hooray for Travis builds... I'll fix that.

Prior99 commented 9 years ago

:+1:

Prior99 commented 9 years ago

Instead of having a parameter ban how about adding a second method for banning people?

tjhorner commented 9 years ago

Sure. This time, the build failing isn't my fault lol. If you want (whoever handles the CI), I have a 24/7 Mumble server at mumble.horner.tj that you can test on.

tjhorner commented 9 years ago

Oh wait, forgot to actually make reason optional... heh

Rantanen commented 9 years ago

Looks good! No idea what's wrong with the travis tests so ignoring those for now.

Rantanen commented 9 years ago

The most important restriction for pull requests is about secure environment variables

Figures. Need to come up with a dedicated test instance of Mumble. It was set to use one used with pile of people so didn't want to publish the address.

tjhorner commented 9 years ago

Well as I said earlier, you could always use mine. 4 or 5 people are usually on it per day, I just set it up for a couple of friends.