search

Rantanen / node-mumble

Mumble client in Node.js
MIT License
155 stars 48 forks source link

Add self mute/deaf to User. closes #73. #74

Closed tjhorner closed 8 years ago

tjhorner commented 8 years ago

Check lines 42 and 51. Will codeclimate complain about this? Should user state sending be wrapped?

Rantanen commented 8 years ago

Think it should be wrapped given we still need the set() method that is able to set multiple flags with a single UserState message as I believe it makes a difference from UI perspective whether the mute and deafen happen at the same time.

And no idea about code climate. Given it complains about everything short of your syntax highlighting colors, I guess it will - but we can entertain it later for that. :)

But neither of these aspects affects the API, etc. so we can go with this for now.

tjhorner commented 8 years ago

it complains about everything short of your syntax highlighting colors

"F - your solarized theme sucks"

Rantanen commented 8 years ago

I'm convinced that is an actual CodeClimate warning.