Rantanen / node-mumble

Mumble client in Node.js
MIT License
155 stars 48 forks source link

'message' event in MumbleClient -> always 'private' message #78

Closed mikemimik closed 8 years ago

mikemimik commented 8 years ago

https://github.com/Rantanen/node-mumble/blob/master/lib/MumbleClient.js#L444

MumbleClient.prototype._textMessage = function(data) {
    var actor = this.sessions[data.actor];
    if(actor) {
        if(data.session !== null) { // THIS WILL NEVER BE FALSE
            this.emit('message', data.message, actor, 'private');
        }
        else if(data.channel_id !== null) { // A message to the channel
            this.emit('message', data.message, actor, 'channel');
        }
    }
};

The statement on line:444 will always be true because session === [] you need to check if it's empty not null.

Will be submitting PR.

mikemimik commented 8 years ago

PR #79 fixes this.