v8 warning for native addon on node v6+

Rantanen / node-mumble

Mumble client in Node.js

MIT License

155 stars 48 forks source link

v8 warning for native addon on node v6+ #92

Closed notthetup closed 7 years ago

notthetup commented 8 years ago

When requiring "mumble", on nodejs v6+, there is a warning from v8 about usage of deprecated APIs. Not sure if this is an node-mumble issue or from one of it's dependencies. I do see mention of both celt and jitterbuffer in the stacktrace.txt

[21:42]chinmay@rayleigh: ❯ node --version
v6.3.1
[21:42]chinmay@rayleigh: ❯ node -e 'require("mumble")'
(node) v8::ObjectTemplate::Set() with non-primitive values is deprecated
(node) and will stop working in the next major release.

tjhorner commented 8 years ago

There isn't anything that compiles here, so it's probably one of those.

Prior99 commented 8 years ago

Bump! Same Problem here. Also with v4.4.5 I get 'Error: Module version mismatch. Expected 46, got 48.' Which version of node are we supposed to use?

Rantanen commented 8 years ago

I'd guess the Module version mismatch is caused by upgrading Node version without rebuilding the packages.

Try removing the node_packages and doing npm install. I'm expecting that to solve the Error.

The warning will still be there. I think it's caused by node-jitterbuffer - but I had trouble building and running that with node-gyp for some reason. I'll take a look at it again soon.

Rantanen commented 7 years ago

Found the issue in node-jitterbuffer. Fixed it there (and in node-celt).