search

RanvierMUD / bundle-example-debug

2 stars 5 forks source link

ipban command not being able to find banned.json #1

Closed nahilep closed 5 years ago

nahilep commented 5 years ago

https://github.com/RanvierMUD/bundle-example-debug/blob/master/commands/ipban.js#L30 the FIXME above this line already states that this has to be fixed, since bundlePath is completely undefined here, this should indeed be an issue.

shawncplus commented 5 years ago

This touches a bit on the data layer change I want to make. For the moment it's probably enough to just have the file in the bundle itself instead of going up into the main data folder

nahilep commented 5 years ago

ipban is not working the way it is written. bannedList.push(target.socket.address().address); is the issue at the moment. target.socket.address() is null and has no property address. I haven't been able to find the ip of a socket. Any hints?