Closed clagiordano closed 5 years ago
I'd prefer the return;
to return null;
. I try to reserve return;
only for void methods but this method's return type is ?string
. Also given that the docblock should be
/**
* @param {string} search
* @return {?string}
*/
Almost, the docblock isn't quite right :)
@shawncplus Do you want a docblock without description?
No, the description is fine. See this comment https://github.com/RanvierMUD/core/pull/44#issuecomment-461895287 The param type should be @param {string}
, separately the return type should be @return {?string}
but keep the description
Oh, sure I mixed params and return type, fine.
Excellent, thank you
Thanks to you, great work!
This PR adds an alternative method to search and returns first helpfile matching topic.