search

RanvierMUD / ranviermud

A node.js based MUD game engine
https://ranviermud.com
MIT License
796 stars 247 forks source link

Issue with re-hydrating effects/cooldowns #133

Closed seanohue closed 7 years ago

seanohue commented 7 years ago

Saved/quit after casting a spell, logged back in with the same character and the server crashed after a short while.

Stack trace:


  - cooldown.js:21 Effect.eventDeactivated
    /Users/seanohue/myProjects/ranviermud/bundles/core-classes/effects/cooldown.js:21:73

  - Effect.js:125 Effect.deactivate
    /Users/seanohue/myProjects/ranviermud/src/Effect.js:125:10

  - EffectList.js:90 EffectList.remove
    /Users/seanohue/myProjects/ranviermud/src/EffectList.js:90:12

  - EffectList.js:100 EffectList.validateEffects
    /Users/seanohue/myProjects/ranviermud/src/EffectList.js:100:14

  - EffectList.js:112 EffectList.evaluateAttribute
    /Users/seanohue/myProjects/ranviermud/src/EffectList.js:112:10

  - Character.js:60 Player.getMaxAttribute
    /Users/seanohue/myProjects/ranviermud/src/Character.js:60:25

  - Character.js:68 Player.getAttribute
    /Users/seanohue/myProjects/ranviermud/src/Character.js:68:17

  - ---------------------------------------------

  - EventManager.js:42 EventManager.attach
    /Users/seanohue/myProjects/ranviermud/src/EventManager.js:42:17

  - EffectFactory.js:61 EffectFactory.create
    /Users/seanohue/myProjects/ranviermud/src/EffectFactory.js:61:24

  - EffectList.js:168 EffectList.hydrate
    /Users/seanohue/myProjects/ranviermud/src/EffectList.js:168:42

  - Character.js:203 Player.hydrate
    /Users/seanohue/myProjects/ranviermud/src/Character.js:203:18

  - Player.js:223 Player.hydrate
    /Users/seanohue/myProjects/ranviermud/src/Player.js:223:11

  - done.js:14 TelnetStream.<anonymous>
    /Users/seanohue/myProjects/ranviermud/bundles/core-input-events/input-events/done.js:14:14

  - ---------------------------------------------

  - EventManager.js:42 EventManager.attach
    /Users/seanohue/myProjects/ranviermud/src/EventManager.js:42:17

  - ranvier:125 Server.Telnet.TelnetServer.socket
    /Users/seanohue/myProjects/ranviermud/ranvier:125:35

  - Telnet.js:256 Server.TelnetServer.netServer.net.createServer
    /Users/seanohue/myProjects/ranviermud/src/Telnet.js:256:22

  - ---------------------------------------------

  - Telnet.js:259 new TelnetServer
    /Users/seanohue/myProjects/ranviermud/src/Telnet.js:259:20

  - ranvier:117 init
    /Users/seanohue/myProjects/ranviermud/ranvier:117:14

  - ranvier:169 Object.<anonymous>
    /Users/seanohue/myProjects/ranviermud/ranvier:169:1
shawncplus commented 7 years ago

I can't reproduce this, could you provide reproduction steps? I tried casing the spell, verifying that I had the cooldown effect, quit, logged back in, no error, still had cooldown effect.

seanohue commented 7 years ago

I'll try reproducing it -- it was while I was working on the mage branch so it might have been my own fault.