search

RanvierMUD / ranviermud

A node.js based MUD game engine
https://ranviermud.com
MIT License
796 stars 247 forks source link

Refactor existing areas to use readable ids rather than numeric #339

Closed seanohue closed 5 years ago

seanohue commented 6 years ago

Description

Having numeric IDs such as limbo:1 and craft:2 makes it very difficult to tell exactly what the room/item/NPC is that is being referenced.

This makes it tough for beginning builders to work with the existing areas, and also leads to the misconception that IDs have to be numeric.

Expected outcome

An ID for an entity reference should be at least somewhat human readable, such as craft:greenplant.

Actual outcome

Many IDs are not human-friendly and consist of a single-digit number.

Steps to reproduce

Look at the default bundle item definitions.

Version of Ranvier

2.0.0 (and all other versions thus far)

Vindexus commented 6 years ago

I can take a crack at this.

Vindexus commented 6 years ago

Pull request: https://github.com/shawncplus/ranviermud/pull/340

Vindexus commented 6 years ago

Any update on that pr?

seanohue commented 6 years ago

I think it looks solid -- I don't have permissions to merge it but I did look over it and didn't see any issues.

shawncplus commented 5 years ago

Closed in #340