search

Rapha149 / ClearFog

Unnerved by 1.18 fog? This Spigot plugin will remove it!
https://www.spigotmc.org/resources/clearfog.98448/
GNU General Public License v3.0
8 stars 2 forks source link

[Feature] Backwards compatibility for use with ViaVersion #1

Open bpx573 opened 2 years ago

bpx573 commented 2 years ago

Hello, is it possible to make this plugin work on 1.17.1 with viaversion so 1.18 clients don't get the fog? If you can't implement the feature publicly we will pay you for it! Add me on discord to discuss!

Discord:

Barry#0 3 6 3 (Had to separate the discord name so it shows up correctly.)

Rapha149 commented 2 years ago

Hey Barry, I didn't think about users wanting to use this plugin with ViaVersion on older versions but it should be possible for me to implement it. Thank you for the idea! However, I don't know how much time I will have during the holidays, so it may take some time until it's implemented.

Rapha

Rapha149 commented 2 years ago

Hey Barry, I have bad news for you. I tried it out today and I found no working way how to do that. I'll leave this issue open, maybe someone else has a solution or an idea.

Rapha

Pantera07 commented 2 years ago

I suggested this feature to ViaVersion a month ago, and they told me to make a plugin with Paper API.

Rapha149 commented 2 years ago

So you mean that it would work with Paper? I could look into that.

Rapha149 commented 2 years ago

I've been thinking about that for a moment and I guess I'll contact ViaVersion myself and ask how I should do it because I don't quite get how the Paper API would help me in this case.

Pantera07 commented 2 years ago

https://github.com/PaperMC/Paper/blob/master/patches/api/0014-Add-view-distance-API.patch

This may be related.

Rapha149 commented 2 years ago

Well that are some Paper methods that could be used to send different view distances in 1.17+ If there is no other way I could implement that but I would be more pleased if there would be a solution with ViaVersion as this would allow me to add support for lower versions and also for Spigot servers.

Pantera07 commented 2 years ago

https://github.com/PaperMC/Paper/blob/ver/1.8.8/Spigot-API-Patches/0011-Add-player-view-distance-API.patch I found a patch that seems to be relevant in 1.8.8.

Rapha149 commented 2 years ago

Yeah, but it says "Not supported yet". Even if you look at the method in 1.16, it's deprecated because it's not implemented then: https://papermc.io/javadocs/paper/1.16/org/bukkit/entity/Player.html#setViewDistance(int)