Rapha149 / SignGUI

An api to get input text via a sign in Minecraft.
MIT License
38 stars 15 forks source link

Add support for 1.21 #13

Closed CyR1en closed 3 months ago

CyR1en commented 3 months ago

This PR contains code to support 1.21 servers.

Test Build Environment:

Notes for review:

Rapha149 commented 3 months ago

Looks good, thank you for contributing! I made one little change, I replaced Entity#cN with Entity#dO (p.cN()p.dO()). I don't think it has an impact, the method Entity#cN points to the method Entity#dO but in the 1_20_R4 wrapper I used the method Entity#dP which looks like this:

public World dP() {
    return this.r;
}

The method in Entity#dO in 1_21_R1 has exactly the same content:

public World dO() {
    return this.r;
}

while the method Entity#cN points to the other method:

public World cN() {
    return this.dO();
}

So it doesn't really change anything, but it now uses the "same" method as in 1_20_R4.

Rapha149 commented 3 months ago

The update is now published on Maven Central.