search

Rapha149 / SignGUI

An api to get input text via a sign in Minecraft.
MIT License
35 stars 12 forks source link

Add support for 1.20.1. #2

Closed ebicep closed 12 months ago

ebicep commented 1 year ago

Added support for the 1.20.1. Left out hanging signs in getSignTypes().

Rapha149 commented 1 year ago

Oh, I forgot to update this api, I'm very sorry! Unfortunately, I'm currently on vacation so I can't review your pull request. I will try to get it done on July 11 but I think July 17 is more likely, because I don't have much time on July 11 and on July 12 I'm on vacation again.

Rapha149 commented 12 months ago

@ebicep after merging your pull request I had to fix a few things but the new release is online now.

You did a really great job, e.g. figuring out the new method for the sign packet but you made mistakes regarding the class SignText:

  1. The methods of this class don't update the current instance, they return a new instance. So you would have had to do signText = signText...
  2. The methods of that class also don't automatically update the TileEntitySign, you have to set the new text using another method of TileEntitySign.

I'm not mentioning this to be mean, only so you can look out for something like that in the future.

Thanks for reminding me to update this and for doing the pull request!