Ains is missing his second skill

RaphaelDDL / e7db-api

V2 - EpicSevenDB.com API for Website, Tools and Discord Bot

Other

24 stars 4 forks source link

Ains is missing his second skill #15

Closed sebeiron closed 3 years ago

sebeiron commented 4 years ago

Fetching Ains details via the hero api https://api.epicsevendb.com/hero/c3093

His second skill ("Gash", Passive) is not listed.

RaphaelDDL commented 4 years ago

Two issues here:

The source data is missing the skill enhancements

Created https://github.com/EpicSevenDB/gamedatabase/issues/257

mongo lookup fails

Because I don't test for array length before doing the $lookup, it fails and the skill is not returned by mongo, so api just sends two skills. Fixing the data source will fix it but I'll also study one how test for length before trying a lookup to avoid these issues in future