search

RaphaelDDL / e7db-ui

EpicSevenDB.com UI for game information, such as Heroes, Artifacts, Gear, Skills and anything else necessary to present the DB. Made with NUXT.js (Vue.js, Express, SASS)
https://epicsevendb.com
Other
10 stars 5 forks source link

Search component on homepage #2

Closed willhausman closed 5 years ago

willhausman commented 5 years ago

First pass working prototype of a search component on the homepage.

This is my first foray into VueJS. I'm open to critique. The actual CSS needs help, but doesn't look absolutely atrocious.

Take note of my use of the stripText util. I would like to alter the other filters to do this same matching, as it is more robust than comparing just name and file id.

RaphaelDDL commented 5 years ago

I'll check out the branch and play a bit with it and give you feedback :)

RaphaelDDL commented 5 years ago

I liked.

I understand the aim you said for the trimmed, so we don't need to do conversion on each model change, makes sense.

I checked it out and made a few changes regarding the loading which you added the isLoading but not using on the template, as well as the css (reused filter-by-name class with a few overrides.

I need to see how I can incorporate my commit on this PR lol, I never did that before on github.. Or I can approve this one then apply mine on top lol.

edit: Also, you did a great job using the store dispatch, so it used the store and kept the data when accessing the other pages. Same by keeping promise all, so if someone directly entered a hero list, then go to home, it'll only trigger the artifact call.

clicks tongue noice!

I'll merge this then create a PR with my changes so you can see and comment on my changes.

willhausman commented 5 years ago

I added you as a collaborator to my fork, but you had already merged and made a new PR. Ha!

RaphaelDDL commented 5 years ago

huehue

So, yeah, I was reading this now https://help.github.com/en/articles/committing-changes-to-a-pull-request-branch-created-from-a-fork

Seems you needed to give me permission, which you did after I merged. Doh, sorry.

My power level too high, I'm too fast, you couldn't see my movements (insert over 9000 meme here)