search

RaphaelDDL / e7db-ui

EpicSevenDB.com UI for game information, such as Heroes, Artifacts, Gear, Skills and anything else necessary to present the DB. Made with NUXT.js (Vue.js, Express, SASS)
https://epicsevendb.com
Other
10 stars 5 forks source link

Add effects to buff/debuff filters #26

Closed Kenford20 closed 4 years ago

Kenford20 commented 4 years ago

#5

idk if the icons for effects were ever added, but feel free to leave this open until then

going to go ahead and open a PR on the database repo to update the hero files to have their respective effects added so that filtering works as expected (seems that only the new heroes have their effects in the buff/debuff array so far)

let me know if i'm missing anything else :)

RaphaelDDL commented 4 years ago

Unfortunately the icons weren't added yet. But I guess the options can be added anyway, because it'll work as long as gamedatabase has the heroes with their buff/debuff updated.

I'll keep this one pending until we get the effects on all heroes at gamedatabase otherwise will feel weird to use one of the new filters and not bringing the correct heroes.

Kenford20 commented 4 years ago

https://github.com/EpicSevenDB/gamedatabase/pull/233

pr is raised!

RaphaelDDL commented 4 years ago

Thanks for that.

With the flip to v2 api we finally have all game's buffs data without needing to hardcode it. Was added on #29 :D