RaphaelRochet / arch-update

Update indicator for ArchLinux and Gnome-Shell
https://extensions.gnome.org/extension/1010/archlinux-updates-indicator/
GNU General Public License v3.0
232 stars 69 forks source link

Gnome 44 support #204

Closed gilvbp closed 1 year ago

gilvbp commented 1 year ago

Using gnome 44 I'm getting this error:

theme.set_custom_theme is not a function

RaphaelRochet commented 1 year ago

And we go again. New GNOME release. Chances are I'll check this when GNOME Shell 44 hits Arch extra.

Neo-29 commented 1 year ago

Will it be ready for arch on time?

RaphaelRochet commented 1 year ago

No it won't. But I will quickly test and release a Gnome 44 compatible version as soon as Gnome 44 drops on Arch's extra repo. Expect it like a day or two after :)

Neo-29 commented 1 year ago

Fair enough... not a big deal

PHLAK commented 1 year ago

FYI, GNOME 44 is now in Arch extras.

RaphaelRochet commented 1 year ago

Good. Then as said, expect a release very soon.

Neo-29 commented 1 year ago

Good. Then as said, expect a release very soon.

Extension fully working as it is 👍😉

RaphaelRochet commented 1 year ago

Oh really ? No issue with gtk theming ? Coooool

Neo-29 commented 1 year ago

nope

image

image

javmorin commented 1 year ago

FYI, I just updated to 44 via official repo, and after tweaking allowed versions for this extension, I get the error reported by @gilvbp theme.set_custom_theme is not a function. Not sure how it's working for @Neo-29

Neo-29 commented 1 year ago

FYI, I just updated to 44 via official repo, and after tweaking allowed versions for this extension, I get the error reported by @gilvbp theme.set_custom_theme is not a function. Not sure how it's working for @Neo-29

Do you use adwaita as shell? No third party?

Neo-29 commented 1 year ago

I suggest if not

RaphaelRochet commented 1 year ago

Damned. I may need to tweak the code a bit after all.

RaphaelRochet commented 1 year ago

Alright. I have the issue. Working on it.

Neo-29 commented 1 year ago

Alright. I have the issue. Working on it.

What's the cause? Theme?

RaphaelRochet commented 1 year ago

Oops, forgot to update metadat ^^" Working nicely, tried with X11 and Wayland.

@javmorin' error may be harder to track down than I though :(

RaphaelRochet commented 1 year ago

@javmorin Do you have "Use builtin icons" enabled ?

javmorin commented 1 year ago

Do you use adwaita as shell? No third party?

Yes, adwaita (default) for all theme settings in gnome. No third party stuff other than extensions.

@javmorin Do you have "Use builtin icons" enabled ?

I didn't, but turning that on seems to have fixed the issue.

RaphaelRochet commented 1 year ago

There's a gtk3 function that was called "set_custom_theme" here, renamed "set_theme_name" in gtk4. I hate when they do this. This bug may be there for a while ...

javmorin commented 1 year ago

I don't recall ever disabling that option, and the built-in icons are fine by me, so no issue on my side if a fix for custom icons isn't quick.

FYI: I see this in the Gnome 44 extension notes: https://gjs.guide/extensions/upgrading/gnome-shell-44.html#gtk-icontheme

RaphaelRochet commented 1 year ago

Thanks for the point. Fun note, I was using this before but switched because it had bugs ... I will probably have to switch again. I have submitted v52 to ego ;)

There's a little bonus : settings now use adwaita style.

RaphaelRochet commented 1 year ago

It's live ;)

Neo-29 commented 1 year ago

It's live ;)

Nice with adwaita style! 👍👍👍.