RaphaelRochet / arch-update

Update indicator for ArchLinux and Gnome-Shell
https://extensions.gnome.org/extension/1010/archlinux-updates-indicator/
GNU General Public License v3.0
232 stars 69 forks source link

Incompatibility with Gnome 46 (beta) #231

Closed ydaveluy closed 7 months ago

ydaveluy commented 8 months ago

Hello,

I tested this extension on Gnome 46 (beta) and it raises a TypeError: this.checkingMenuItem.actor.add_actor is not a function I think that it comes from: https://github.com/RaphaelRochet/arch-update/blob/967add5f20c1b86716571048080285d5a17f2a49/extension.js#L131

RaphaelRochet commented 8 months ago

I can't believe they manage to break extensions on each and every release. Like always, will test and (hopefully) fix when it will hit Arch's repos. Any ideas when the release is planned ?

ydaveluy commented 8 months ago

It should be out on 20 March

Kerrung commented 8 months ago

I can't believe they manage to break extensions on each and every release. Like always, will test and (hopefully) fix when it will hit Arch's repos. Any ideas when the release is planned ?

@RaphaelRochet You don't need to wait for GNOME 46 to appear in the Arch Linux stable repositories. Just install GNOME OS Nightly in a virtual machine and test it there. https://os.gnome.org/

RaphaelRochet commented 8 months ago

@RaphaelRochet You don't need to wait for GNOME 46 to appear in the Arch Linux stable repositories. Just install GNOME OS Nightly in a virtual machine and test it there.

Yep I don"t have t. I want to.

RaphaelRochet commented 8 months ago

Looks like I can reproduce with gnome-shell beta from gnome-unstable repo. Will see if this is an easy fix.

RaphaelRochet commented 8 months ago

Fixed this one, but now blocking on MessageTray.SystemNotificationSource change :tired_face:

RaphaelRochet commented 8 months ago

Ok, done too. Looks promisin :) Only a little bug left !

RaphaelRochet commented 8 months ago

Ready for testing (branch Gnome46). Let's hop I caught all bugs. Tell me :)

ydaveluy commented 8 months ago

Yes everything seems fixed, no issue on my side after few updates

Kerrung commented 8 months ago

562d7c91a2211fde6152f2ea8cb7b00f0734e4aa It doesn't work for me on GNOME 46 from [gnome-unstable]. Screenshot from 2024-03-09 21-31-35

RaphaelRochet commented 8 months ago

Ok, disable the manual ordering thin in the options, should work.

Kerrung commented 8 months ago

Ok, disable the manual ordering thin in the options, should work.

I didn't realise what exactly I should disable. Can you please send me a screenshot of this particular setting or at least tell me its exact name? Or maybe it would be better to make your extension work with any enabled settings as it was before?

RaphaelRochet commented 8 months ago

It's the option that allow you to set indicator position. Of course I will have to fix this bug. I may remove that feature altogether if needed.

Kerrung commented 8 months ago

It's the option that allow you to set indicator position. Of course I will have to fix this bug. I may remove that feature altogether if needed.

This feature is very much needed to use. I would like to keep it working, please.

RaphaelRochet commented 8 months ago

That was an easy fix. But I found another bug on notifications (related to new notification management in 46). Working on it.

RaphaelRochet commented 8 months ago

A few fixes later all seems to work fine. More testing may be a good thing if you don't mind. ( ea2de9e1cd79341f46d415657ecebe507ad15026, dc78270c00743b22e9c2e3145ae2e73a71f4e706 )

grg3 commented 7 months ago

46 just hit Arch! Thankfully, this extension is still working even though it reports an error: Error: Extension point conflict: there is already a status indicator for role ArchUpdateIndicator

RaphaelRochet commented 7 months ago

I can't reproduce this error. Do you have any more info ?

Neo-29 commented 7 months ago

I've got a issue here

I've got for example six pending updates but if I click on it nothing image

RaphaelRochet commented 7 months ago

I can't reproduce this either. That's annoying. Another extension messing with indicators maybe ?

Neo-29 commented 7 months ago

Can't say... It was working properly with the same extensions on. I'll investigate.

Neo-29 commented 7 months ago

The AUR package is broken too

RaphaelRochet commented 7 months ago

Flag it, can't do much about it. Hope the maintainer will update it quickly.

Neo-29 commented 7 months ago

Got it...

That must be off otherwise the issue occurs

image

RaphaelRochet commented 7 months ago

Ok. I could reproduce this with an error "JS ERROR: TypeError: this.menuExpander.menu.box.add is not a function". Will fix that, should be an easy fix.

RaphaelRochet commented 7 months ago

Should be fixed in Master branch ;) I caught another error in the meanwhile :grin:

Neo-29 commented 7 months ago

Should be fixed in Master branch ;) I caught another error in the meanwhile 😁

Nice!

I'll wait for the extension to be pushed on the site