bug in get_pycox_activation

RaphaelS1 / survivalmodels

Implementations of survival models in R

https://raphaels1.github.io/survivalmodels/

Other

57 stars 13 forks source link

bug in get_pycox_activation #29

Closed sebffischer closed 2 years ago

sebffischer commented 2 years ago

See: https://github.com/mlr-org/mlr3extralearners/issues/182

The bug is in get_pycox_activation

The lines 316 - 321 all construct the activation function even when construct = FALSE

sebffischer commented 2 years ago

Also I think that it is quite unexpected that the parameter values for an activaton function are not used when construct = FALSE, this should at least throw a message or something

RaphaelS1 commented 2 years ago

closed in #33