add parametric model - Githubissues

RaphaelS1 commented 9 months ago

@bblodfon if you could help tick off this list that would be very helpful to get this over the line

[x] Add tests
[x] Add test confirming lp <> risk order is same for all model forms
[x] Confirm same results from mlr3extralearners
[x] Add docs
[x] Add note that distr6 return is always TRUE if return type is continuous
[ ] Reimplement in extralearners https://github.com/mlr-org/mlr3extralearners/issues/41

RaphaelS1 commented 8 months ago

@bblodfon tests now passing, please review when you have time

codecov-commenter commented 8 months ago

Codecov Report

Attention: Patch coverage is 96.84211% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 35.40%. Comparing base (9d59b0c) to head (feb9476). Report is 8 commits behind head on main.

Files	Patch %	Lines
R/parametric.R	97.15%	5 Missing :warning:
R/methods.R	75.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #45 +/- ## ============================================ - Coverage 100.00% 35.40% -64.60% ============================================ Files 16 18 +2 Lines 780 983 +203 ============================================ - Hits 780 348 -432 - Misses 0 635 +635 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

RaphaelS1 / survivalmodels

add parametric model #45

Codecov Report