search

RaphiMC / ImmediatelyFast

Speed up immediate mode rendering in Minecraft
https://modrinth.com/mod/immediatelyfast
GNU Lesser General Public License v3.0
294 stars 21 forks source link

1.20-1.20.4 NeoForge builds are not compatible with 1.20.1 NeoForge #178

Closed MrFastZombie closed 9 months ago

MrFastZombie commented 9 months ago

The NeoForge builds are marked as 1.20.1 compatible on Modrinth and Curseforge but do not launch successfully.

I'm guessing the NeoForge builds are not supposed to support 1.20.1 since NeoForge on that version didn't completely split from Forge yet. The newer 1.20.1 compatible Forge builds do seem to work fine with 1.20.1 NeoForge.

The error given when trying to run the NeoForge builds on 1.20.1 is ImmediatelyFast-NeoForge-1.2.9+1.20.4.jar constructed 0 mods: [], but had 1 mods specified: [immediatelyfast]. I tested both 1.2.9 and 1.2.10 on an instance with only ImmediatelyFast to verify.

Gaming32 commented 9 months ago

Well the error message you gave says you tried to launch a 1.20.4 jar.

MrFastZombie commented 9 months ago

Well the error message you gave says you tried to launch a 1.20.4 jar.

The jar is marked as 1.20-1.20.4 on the Modrinth and Curseforge pages. Here's the Modrinth page for 1.2.10 for example. 1.20.4 is just the latest version the jar supports as far as I can tell. The Forge version is also a 1.20.4 jar, but it will launch on 1.20.1.

The problem is that the latest NeoForge jars are built for NeoForge versions that are after the breaking changes, and don't seem to work with 1.20.1 NeoForge as a result but are still marked as compatible with that version on the mod pages.

RaphiMC commented 9 months ago

This was caused by the auto publishing script. Fixed the version range of the NeoForge jars