search

RaphiMC / ImmediatelyFast

Speed up immediate mode rendering in Minecraft
https://modrinth.com/mod/immediatelyfast
GNU Lesser General Public License v3.0
294 stars 21 forks source link

Tab list is blacked out / Essential mod compatibility (1.20.4) #213

Closed Hlebuw3k closed 5 months ago

Hlebuw3k commented 6 months ago

The current workaround is to "Just disable the Essential indicator in tab-list on essential settings" as yichifauzi has pointed out. With mod: Снимок экрана 2024-05-12 070944 Without mod: Снимок экрана 2024-05-12 070119 Modlist (ImmediatelyFast removed due to tab list blackout): modlist

RaphiMC commented 6 months ago

Please try to reproduce this problem only with ImmediatelyFast installed. If it doesn't happen with only ImmediatelyFast installed try finding out which mod causes it in combination with ImmediatelyFast. When you reproduced the bug with a minimal mod list upload the game log

yichifauzi commented 6 months ago

2024-05-21_02 07 24

https://mclo.gs/oAK2vYc

the bug happen when using essential mod when in server.... need to report on essential side....

EDIT: I been report to them and i found a temporary solution for essential Just disable the Essential indicator in tab-list on essential settings

DJtheRedstoner commented 5 months ago

Hi, Essential developer here.

I've identified that this is caused by your HUD Batching feature. We have a feature which renders a diamond indicator in the tab menu next to player names to show other players that are using Essential. image

Our code is pretty simple, however it notably doesn't use DrawContext's methods due to the wide range of versions we support (and since there's none that are appropriate for this diamond/rotated square anyways). This seems to be what causes the issue to occur, since PlayerListHud is batched.

Would the appropriate fix here be to use the api to implement something like the armor chroma compat mixin? I'd rather this be on our side (as opposed to a compat mixin in ImmediatelyFast), since this code will likely change in the future. A quick test seems to show that this works.

PolyframeX commented 5 months ago

This issue occures on 1.20.1 as well.

RaphiMC commented 5 months ago

@DJtheRedstoner A fix similar to the armor chroma fix should work and would be the ideal solution if the underlying rendering code doesn't use DrawContext and thus can't be easily batched with IF.

LordEnder-Kitty commented 5 months ago

@yichifauzi Oh my gosh, thank you. i tried to figure out what was causing the issue but couldn't find in in my testing because i didn't think Essential would be the problem. I've also noticed that Essential emotes aren't rendering. im not sure if that's also this mod causing the issue, but it started around when i updated this, so.

Reinified commented 5 months ago

I have an issue just like this with immediatleyfast & essentials mod in my modpack, however it seems to block out certain names at random in the tablist

examples: image image

Hlebuw3k commented 5 months ago

Essential Mod fixed this in the version 1.3.2.5, change log: https://modrinth.com/mod/essential/version/vXxBUert (tested it myself in-game to make sure, the issue no longer occurs)