search

RaphiMC / ImmediatelyFast

Speed up immediate mode rendering in Minecraft
https://modrinth.com/mod/immediatelyfast
GNU Lesser General Public License v3.0
288 stars 21 forks source link

[Bug] JourneyMap and f3 screen when minimap is enabled. #254

Closed mysticdrew closed 1 month ago

mysticdrew commented 2 months ago

A user reported this to me, they are running ImmediatelyFast-Fabric-1.2.18+1.21, they issue happens with all versions of JM for 1.21.

The f3 text is light grey when the minimap is enabled and text on the minimap is drawing, infoslots and n|e|s|w points. I call GuiGraphics#drawString and this happens. When I disable text from drawing, the f3 screen is normal. I am not doing anything fancy here.

image

RaphiMC commented 2 months ago

Try removing all other mods except for ImmediatelyFast and JourneyMap and check if the issue still happens

mysticdrew commented 2 months ago

Try removing all other mods except for ImmediatelyFast and JourneyMap and check if the issue still happens

I verified that it occurs with with only jm, fapi, and IF.

RaphiMC commented 2 months ago

Try removing all other mods except for ImmediatelyFast and JourneyMap and check if the issue still happens

I verified that it occurs with with only jm, fapi, and IF.

Upload the game log of that session

mysticdrew commented 2 months ago

There are no errors, I'm not at my pc. Might be quicker to toss jm in your dev env to verify.

Join game, press f3 see problem.

tajemniktv commented 1 month ago

Can also confirm. Opening chat somehow makes the F3 text go white as it should instead of light gray

EDIT: Removed edited update, made a new comment

tajemniktv commented 1 month ago

Update: It... fixed itself? By removing JourneyMap config files, updating JM and/or updating ImmediatelyFast... Not sure if these were even the "fixes" I applied that helped lol Discovered this by accident

RaphiMC commented 1 month ago

@mysticdrew Can you also confirm if the issue is fixed?

mysticdrew commented 1 month ago

Here is the situation, I found a work around. For the minimap text drawing, I was using GuiGraphics#drawString which was being broken by IF.

I switched to using Font#drawInBatch which fixed it.

However, you should also make sure you are not breaking the GuiGraphics#drawString methods in IF as that is the standard way of drawing text.

RaphiMC commented 1 month ago

I am very certain that GuiGraphics#drawString is not broken by IF because minecraft uses it all over the place for its own rendering. I assume there was another factor at play which caused some GL state to get corrupted.

mysticdrew commented 1 month ago

I am very certain that GuiGraphics#drawString is not broken by IF because minecraft uses it all over the place for its own rendering. I assume there was another factor at play which caused some GL state to get corrupted.

That is kind of what it seems like. I tried to use RenderDoc to look into it but I didn't come up with much. But my RenderDoc skills are not great. The issue on my end was resolved in beta.19, if you are any good with RenderDoc and can see something happening in beta.18 and IF.