High fps drops with REI.

Minecrafthyr commented 1 year ago

With ImmediatelyFast: 4fps https://spark.lucko.me/jSEexP4wwb Without ImmediatelyFast: 20fps https://spark.lucko.me/b6H2e047Kz Mod list:

alternate-current 1.5.0
appleskin 2.4.3+mc1.19.4
architectury 8.1.79
attributefix 19.0.1
bettercommandblockui 0.4.2
betterstats 2.5.2+1.19.4 -- tcdcommons 2.5.1+1.19.4
bookshelf 18.0.2
bsvsb 3.0.3
c2me 0.2.0+alpha.10.51 |-- c2me-base 0.2.0+alpha.10.51 |-- c2me-client-uncapvd 0.2.0+alpha.10.51 |-- c2me-fixes-chunkio-threading-issues 0.2.0+alpha.10.51 |-- c2me-fixes-general-threading-issues 0.2.0+alpha.10.51 |-- c2me-fixes-worldgen-threading-issues 0.2.0+alpha.10.51 |-- c2me-fixes-worldgen-vanilla-bugs 0.2.0+alpha.10.51 |-- c2me-notickvd 0.2.0+alpha.10.51 |-- c2me-opts-allocs 0.2.0+alpha.10.51 |-- c2me-opts-chunk-access 0.2.0+alpha.10.51 |-- c2me-opts-chunkio 0.2.0+alpha.10.51 |-- c2me-opts-math 0.2.0+alpha.10.51 |-- c2me-opts-scheduling 0.2.0+alpha.10.51 |-- c2me-opts-worldgen-general 0.2.0+alpha.10.51 |-- c2me-opts-worldgen-vanilla 0.2.0+alpha.10.51 |-- c2me-rewrites-chunkio 0.2.0+alpha.10.51 |-- c2me-server-utils 0.2.0+alpha.10.51 |-- c2me-threading-chunkio 0.2.0+alpha.10.51 |-- c2me-threading-lighting 0.2.0+alpha.10.51 |-- c2me-threading-worldgen 0.2.0+alpha.10.51 |-- com_electronwill_night-config_core 3.6.5 |-- com_electronwill_night-config_toml 3.6.5 |-- com_github_llamalad7_mixinextras 0.1.1 |-- com_ibm_async_asyncutil 0.1.0 |-- net_objecthunter_exp4j 0.4.8 -- org_threadly_threadly 7.0
clientcommands 2.7.11 -- clientarguments 1.4.3
cloth-config 10.0.96 -- cloth-basic-math 0.6.1
darkutils 15.0.1
dashloader 5.0.0-alpha.13+1.19.4 |-- com_github_luben_zstd-jni 1.5.2-2 |-- dev_quantumfusion_hyphen 0.4.0-rc.3 -- dev_quantumfusion_taski 2.1.0
dcch 2.0+1.17
entityculling 1.6.2-mc1.19.4
exordium 1.0.3-mc1.19.4
extended_drawers 1.3.9+mc.1.19.4 |-- graphlib 0.5.0+1.19.4 -- mconfig 1.2.0+mc.1.19-rc1 |-- de_poiu_apron_apron 2.1.1 -- fabric-permissions-api-v0 0.1-SNAPSHOT
fabric-api 0.78.0+1.19.4 |-- fabric-api-base 0.4.23+9ff28bcef4 |-- fabric-api-lookup-api-v1 1.6.24+49abcf7ef4 |-- fabric-biome-api-v1 13.0.6+348a9c64f4 |-- fabric-block-api-v1 1.0.5+e022e5d1f4 |-- fabric-blockrenderlayer-v1 1.1.33+c2e6f674f4 |-- fabric-client-tags-api-v1 1.0.14+1134c5b8f4 |-- fabric-command-api-v1 1.2.26+f71b366ff4 |-- fabric-command-api-v2 2.2.5+e719b857f4 |-- fabric-commands-v0 0.2.43+df3654b3f4 |-- fabric-containers-v0 0.1.53+df3654b3f4 |-- fabric-content-registries-v0 3.5.8+ae0966baf4 |-- fabric-convention-tags-v1 1.4.0+9a7c5daaf4 |-- fabric-crash-report-info-v1 0.2.14+aeb40ebef4 |-- fabric-data-generation-api-v1 11.3.7+5da15ca1f4 |-- fabric-dimensions-v1 2.1.44+7f87f8faf4 |-- fabric-entity-events-v1 1.5.12+e45f7c65f4 |-- fabric-events-interaction-v0 0.4.42+a1ccd7bff4 |-- fabric-events-lifecycle-v0 0.2.51+df3654b3f4 |-- fabric-game-rule-api-v1 1.0.32+a1ccd7bff4 |-- fabric-item-api-v1 2.1.16+09a3510cf4 |-- fabric-item-group-api-v1 3.0.4+043f9acff4 |-- fabric-key-binding-api-v1 1.0.32+c477957ef4 |-- fabric-keybindings-v0 0.2.30+df3654b3f4 |-- fabric-lifecycle-events-v1 2.2.14+5da15ca1f4 |-- fabric-loot-api-v2 1.1.26+75e98211f4 |-- fabric-loot-tables-v1 1.1.30+9e7660c6f4 |-- fabric-message-api-v1 5.1.0+1ee8be40f4 |-- fabric-mining-level-api-v1 2.1.38+49abcf7ef4 |-- fabric-models-v0 0.3.29+11ba9c3bf4 |-- fabric-networking-api-v1 1.3.0+a6f3ccfaf4 |-- fabric-networking-v0 0.3.40+df3654b3f4 |-- fabric-object-builder-api-v1 7.0.2+63b515f4f4 |-- fabric-particles-v1 1.0.22+f1e4495bf4 |-- fabric-recipe-api-v1 1.0.7+a1ccd7bff4 |-- fabric-registry-sync-v0 2.1.3+a383ab97f4 |-- fabric-renderer-api-v1 2.2.4+81e8c576f4 |-- fabric-renderer-indigo 1.1.0+81e8c576f4 |-- fabric-renderer-registries-v1 3.2.37+df3654b3f4 |-- fabric-rendering-data-attachment-v1 0.3.27+afca2f3ef4 |-- fabric-rendering-fluids-v1 3.0.20+f1e4495bf4 |-- fabric-rendering-v0 1.1.40+df3654b3f4 |-- fabric-rendering-v1 2.1.0+8f878217f4 |-- fabric-resource-conditions-api-v1 2.3.0+e6c7d4eef4 |-- fabric-resource-loader-v0 0.11.1+1e1fb126f4 |-- fabric-screen-api-v1 1.0.44+8c25edb4f4 |-- fabric-screen-handler-api-v1 1.3.19+5da15ca1f4 |-- fabric-sound-api-v1 1.0.8+75e98211f4 |-- fabric-transfer-api-v1 3.1.0+d51205dbf4 -- fabric-transitive-access-wideners-v1 3.0.2+63b515f4f4
fabric-language-kotlin 1.9.4+kotlin.1.8.21 |-- org_jetbrains_kotlin_kotlin-reflect 1.8.21 |-- org_jetbrains_kotlin_kotlin-stdlib 1.8.21 |-- org_jetbrains_kotlin_kotlin-stdlib-jdk7 1.8.21 |-- org_jetbrains_kotlin_kotlin-stdlib-jdk8 1.8.21 |-- org_jetbrains_kotlinx_atomicfu-jvm 0.20.2 |-- org_jetbrains_kotlinx_kotlinx-coroutines-core-jvm 1.6.4 |-- org_jetbrains_kotlinx_kotlinx-coroutines-jdk8 1.6.4 |-- org_jetbrains_kotlinx_kotlinx-datetime-jvm 0.4.0 |-- org_jetbrains_kotlinx_kotlinx-serialization-cbor-jvm 1.5.0 |-- org_jetbrains_kotlinx_kotlinx-serialization-core-jvm 1.5.0 -- org_jetbrains_kotlinx_kotlinx-serialization-json-jvm 1.5.0
fabricloader 0.14.19
fastload 3.3.7 |-- conditional-mixin 0.3.2 |-- fastload-119-0-1-2-compat 3.3.7 |-- fastload-1193-compat 3.3.7 |-- fastload-1194-compat 3.3.7 -- fastload_fapi_forward 1.0.1
fastquit 2.1.0+1.19.3
fpsreducer 1.19.4-2.3
freecam 1.1.9+1.19
globalpacks 1.16_fabric
held-item-info 1.4.2
ibeeditor 2.2.2
indium 1.0.15+mc1.19.4
inventorysorter 1.8.10-1.19.4 -- kyrptconfig 1.5.2-1.19.4
invmove 0.8.3
itemalchemy 0.5.6
java 17
languagereload 1.5.5+1.19.4
lazydfu 0.1.3
lithium 0.11.1
magnetcraft 1.5
mcpitanlibarch 1.6.3-1.19.4-fabric -- org_yaml_snakeyaml 2.0
methane 1.7
minecraft 1.19.4
modmenu 6.2.1 |-- fabric-api-base 0.4.23+9ff28bcef4 |-- fabric-key-binding-api-v1 1.0.32+c477957ef4 |-- fabric-lifecycle-events-v1 2.2.14+5da15ca1f4 -- fabric-screen-api-v1 1.0.44+8c25edb4f4
morechathistory 1.1.1
moreculling 1.19.4-0.17.0
nbtedit 1.19.4-4.2.3-release
nbtgrab 1.2
nounusedchunks 1.3.2
noxesium 0.1.8
omnihopper 1.2.0+1.19.4 -- cooldown-coordinator 0.4.3
reeses-sodium-options 1.5.0+mc1.19.4-build.72
roughlyenoughitems 11.0.597 -- error_notifier 1.0.9
roughlyenoughprofessions 1.2.1
roughlyenoughresources 2.8.0
rrls 1.5.0-fabric
seaborgium 0.1.0
servercommands 1.1.0___1.19.3-1.19.4
simply-no-shading 6.0.6+1.19.4 -- spruceui 4.2.0+1.19.4
smoothboot 1.19.4-1.7.0
sodium 0.4.10+build.24
sodium-extra 0.4.18+mc1.19.4-build.100 |-- caffeineconfig 1.1.0+1.17 -- crowdin-translate 1.4+1.19.3
spark 1.10.37 -- fabric-permissions-api-v0 0.1-SNAPSHOT
suggestion_tweaker 1.19.1-1.4.1
symbol-chat 1.19.4-0.7.6
techreborn 5.7.0 |-- reborncore 5.7.0 | -- team_reborn_energy 3.0.0 -- team_reborn_energy 3.0.0
toolleveling 1.19.4-1.4.5
vmp 0.2.0+beta.7.71

RaphiMC commented 1 year ago

Can you post your exact computer specs?

Minecrafthyr commented 1 year ago

Minecraft Version: 1.19.4
Minecraft Version ID: 1.19.4
Operating System: Windows 10 (amd64) version 10.0
Java Version: 17.0.1, Oracle Corporation
Java VM Version: OpenJDK 64-Bit Server VM (mixed mode, sharing), Oracle Corporation
Memory: 1403201104 bytes (1338 MiB) / 2575302656 bytes (2456 MiB) up to 5368709120 bytes (5120 MiB)
CPUs: 8
Processor Vendor: AuthenticAMD
Processor Name: AMD Ryzen 5 3500U with Radeon Vega Mobile Gfx  
Identifier: AuthenticAMD Family 23 Model 24 Stepping 1
Microarchitecture: Zen / Zen+
Frequency (GHz): 2.10
Number of physical packages: 1
Number of physical CPUs: 4
Number of logical CPUs: 8
Graphics card #0 name: AMD Radeon(TM) Vega 8 Graphics
Graphics card #0 vendor: Advanced Micro Devices, Inc. (0x1002)
Graphics card #0 VRAM (MB): 1024.00
Graphics card #0 deviceId: 0x15d8
Graphics card #0 versionInfo: DriverVersion=26.20.11030.22001
Graphics card #1 name: Virtual Display Device
Graphics card #1 vendor: Huawei
Graphics card #1 VRAM (MB): 0.00
Graphics card #1 deviceId: unknown
Graphics card #1 versionInfo: DriverVersion=1.0.0.9
Memory slot #0 capacity (MB): 8192.00
Memory slot #0 clockSpeed (GHz): 2.67
Memory slot #0 type: DDR4
Memory slot #1 capacity (MB): 8192.00
Memory slot #1 clockSpeed (GHz): 2.67
Memory slot #1 type: DDR4
Virtual memory max (MB): 22516.28
Virtual memory used (MB): 19289.84
Swap memory total (MB): 7220.64
Swap memory used (MB): 699.42

RaphiMC commented 1 year ago

As a temporary fix disabling "fast_buffer_upload" in the config should fix the problem

warior456 commented 1 year ago

there doesn't seem to be a difference with disabling that except even more fps loss

RaphiMC commented 1 year ago

Can you please retest with the latest version for 1.19.4/1.20. I recoded the fast_buffer_upload optimization and some other internals

warior456 commented 1 year ago

I downloaded the mod today

warior456 commented 1 year ago

@RaphiMC

RaphiMC commented 1 year ago

Can you send a spark report of the issue and the client log

warior456 commented 1 year ago

Im on vacation rn I'll try to remember it

Minecrafthyr commented 10 months ago

This is a test in 1.20.2, RoughlyEnoughItems v13.0.678, ImmediatelyFast v1.2.7, fabric-api, architectury, cloth-config, spark. With ImmediatelyFast (about 45 ms related (27ms on item)): https://spark.lucko.me/O8008lG6U4 With ImmediatelyFast, fast_buffer_upload disabled (about 36 ms related (14 ms on item)): https://spark.lucko.me/tjF1RdE2xH Without ImmediatelyFast (about 32 ms related (11 ms on item)): https://spark.lucko.me/kjoPaz437X

RaphiMC / ImmediatelyFast

High fps drops with REI. #58