RaphiMC / ImmediatelyFast

Speed up immediate mode rendering in Minecraft
https://modrinth.com/mod/immediatelyfast
GNU Lesser General Public License v3.0
294 stars 21 forks source link

[1.1.17] Text rendering order on overlapping text is wrong (again) #91

Open kristofbolyai opened 1 year ago

kristofbolyai commented 1 year ago

The issue is basically the same as https://github.com/RaphiMC/ImmediatelyFast/issues/50. Looks like 1.1.17 undid the fixes. I can confirm that 1.1.16 worked.

If you need any specific info, logs, let me know.

RaphiMC commented 1 year ago

Can you provide screenshots and a way to reproduce it please

kristofbolyai commented 1 year ago

image

Combined with Wynntils Artemis v0.0.3-alpha.213. This happens with all versions of the mod, but I would recommend testing against that version, as it is the most stable.

As for reproducing, it seems that this happens less frequently than it did before 1.1.16. The root of the issue is the same, rendering 2 fonts on top of each other, and also rendering some semi-transparent texture triggers it. In Wynntils' sense, this is the low health indicator and the spell cast renderer vignette, which both render semi-transparent textures.

kristofbolyai commented 1 year ago

This is how the right side is supposed to look like for reference. image

SaltSouls commented 1 year ago

I'm also, having this issue, but it is with the level and potion text. Would you be willing to send your mod list so that I could possibly compare and figure out if there is a common mod we are using that could be causing this?

RaphiMC commented 1 year ago

@SaltSouls Does it happen with only IF for you or not? Can you try that please

SaltSouls commented 1 year ago

It seems to be a bug with the newest version... after downgrading from 1.2.3 to 1.2.1, the issue went away. I will try 1.2.3 by itself to see if it still happens.

RaphiMC commented 1 year ago

Are you using Forge or Fabric?

SaltSouls commented 1 year ago

Forge.

RaphiMC commented 1 year ago

The Forge version had broken HUD batching (It didn't do anything) until 1.2.2. So I assume its the HUD batching causing issues on forge

SaltSouls commented 1 year ago

Yeah, the issue persists even when IM is the only mod installed. I will add that this seems to be a 1.19 issue as when testing on 1.20 this problem doesn't appear.

RaphiMC commented 1 year ago

@SaltSouls The xp level text issue will be fixed in the next release (#115)

kurtramone commented 1 year ago

I can confirm this issue with last version of ImmediatlyFast Maybe layers out of order? MC 1.19.2 Forge: 43.2.21 IM: 1.2.3

Some exemples: From Inventory no problems: Captura de tela 2023-09-12 220246 From backpack missing info Captura de tela 2023-09-12 220300 XP text, but you guys already now Captura de tela 2023-09-12 220347 From OneProbe seems some layers are out of order Captura de tela 2023-09-12 220523 Had some issues with AE2 too, but I forgot to save

RaphiMC commented 1 year ago

@kurtramone Can you try with this version and see how many issues remain: https://upload.raphimc.net/file/NSEEbZs9dlTy3cYu/Pf3mvZZuLy7z42ex/ImmediatelyFast-1.2.4-SNAPSHOT%2B1.19.2.jar

kurtramone commented 1 year ago

@kurtramone Can you try with this version and see how many issues remain: https://upload.raphimc.net/file/NSEEbZs9dlTy3cYu/Pf3mvZZuLy7z42ex/ImmediatelyFast-1.2.4-SNAPSHOT%2B1.19.2.jar

Got a crash with this file crash-2023-09-13_14.14.05-client.txt It this file for Forge?

SaltSouls commented 1 year ago

Seems it caused some kinda issue with computer craft.

RaphiMC commented 1 year ago

Fixed the issue, please try again: https://upload.raphimc.net/file/00skGjeBm8hhOe5D/kFomHd9oXyxZbx7n/ImmediatelyFast-1.2.4-SNAPSHOT%2B1.19.2.jar https://upload.raphimc.net/file/ojkmbC8AtNq8Xnjn/zoJStRrFUuf7B3zw/ImmediatelyFast-1.2.4-SNAPSHOT%2B1.20.1.jar

kurtramone commented 1 year ago

Fixed the issue, please try again: https://upload.raphimc.net/file/00skGjeBm8hhOe5D/kFomHd9oXyxZbx7n/ImmediatelyFast-1.2.4-SNAPSHOT%2B1.19.2.jar https://upload.raphimc.net/file/ojkmbC8AtNq8Xnjn/zoJStRrFUuf7B3zw/ImmediatelyFast-1.2.4-SNAPSHOT%2B1.20.1.jar

This snapshot works, no crashes, just little issues with UI, still looks out of order/transparent/fade

OneProbe with issues Captura de tela 2023-09-13 171634 Stats in inventory OK Captura de tela 2023-09-13 171651 Stats from back pack invisble Captura de tela 2023-09-13 171711 XP text OK Captura de tela 2023-09-13 171740 OneProbe from energy cube (Mekanism), it can't load energy bar at bottom/blank artifact Captura de tela 2023-09-13 171819

You can see what I mean by looking at this older version IF 1.2.1 Captura de tela 2023-09-13 172543 Captura de tela 2023-09-13 172450 Captura de tela 2023-09-13 172517 Captura de tela 2023-09-13 172555 Captura de tela 2023-09-13 172359

I'll keep testing this snapshot version for more issues.

RaphiMC commented 1 year ago

The UI issues with modded elements will be fixed at a later point. Its a bit more complex to fix those properly

kurtramone commented 1 year ago

Thanks for helping, that was super fast, if you need help with 1.19.2 just let me know (I'll wait for NeoForge in 1.20.2 to test it).