RaphiMC / ImmediatelyFast

Speed up immediate mode rendering in Minecraft
https://modrinth.com/mod/immediatelyfast
GNU Lesser General Public License v3.0
294 stars 21 forks source link

Large custom font characters break on IF 1.1.17+ #98

Closed MultiverShaun closed 1 year ago

MultiverShaun commented 1 year ago

Large custom characters in the default.json file of my resource pack break on any version of ImmediatelyFast above 1.1.16. This also happens when IF is the only mod. It also happens in titles and in chat.

With IF 1.1.17+:

image image

Without IF/IF 1.1.16 and below:

image image

Notice how the custom diamond (♢) symbols remain functional.

Characters in default.json

{
    "file": "permafrost:font/permafrost_small_caps.png",
    "chars": ["\ue242"],
    "height": 11,
    "ascent": 10,
    "type": "bitmap"
},
{
    "file": "permafrost:font/permafrost.png",
    "chars": ["\ue237"],
    "height": 14,
    "ascent": 5,
    "type": "bitmap"
}

Steps to reproduce

  1. Create large custom font characters with a resource pack
  2. Run Minecraft with ImmediatelyFast 1.1.17 or above
  3. Notice how said custom characters will not work

Misc. Info

Game version: 1.20.1 Loader: Quilt IF version: IF 1.1.17-1.1.25

RaphiMC commented 1 year ago

Does the bug also happen in 1.1.25? Did you test that? Also can you provide a whole resource pack for me to download / the server address so I can test it myself

MultiverShaun commented 1 year ago

Does the bug also happen in 1.1.25? Did you test that? Also can you provide a whole resource pack for me to download / the server address so I can test it myself

Yes, it happens on ImmediatelyFast 1.1.25 too. Here's the resource pack minus all the non-font related stuff: IF_Font_Issue_Resource_Pack.zip

RaphiMC commented 1 year ago

The pack doesn't load. It unloads immediately again due to multiple errors

MultiverShaun commented 1 year ago

The pack doesn't load. It unloads immediately again due to multiple errors

Really sorry, this one should work: IF_Font_Issue_Resource_Pack.zip

RaphiMC commented 1 year ago

image Can't reproduce the issue. The image renders fine if I write that character in the chat

MultiverShaun commented 1 year ago

image Can't reproduce the issue. The image renders fine if I write that character in the chat

Just tested that pack myself and the issue is in fact gone. I'm fairly certain the issue has something to do with my actual resource pack's shaders then, probably unrelated to IF. Sorry to bother you! I'll close this issue now.

TehBrian commented 1 year ago

Not sure if this is related, but ImmediatelyFast 1.2.6 seems to remove vanilla Minecraft's bitmap texture limitation of 256x256. Is that intended behavior?

RaphiMC commented 1 year ago

Yes this is intended as the default is way too small for fitting many high resolution characters on a single glyph page

TehBrian commented 1 year ago

Gotcha. I didn't see that documented on any of the mod's pages, so I wasn't sure.