search

RaphielGang / Telegram-Paperplane

The Paperplane userbot project - a Telegram userbot helping to improve your Telegram experience. https://t.me/tgpaperplane
Other
289 stars 1.06k forks source link

PMing users for the first time should auto-accept them for PM. #108

Closed PaulSonOfLars closed 5 years ago

PaulSonOfLars commented 5 years ago

As one of the people not using this userbot, I find that when someone using it PMs me first, I'll get the "bleep blop I'm a bot" message as soon as I reply.

steps to reproduce:

userbot user: starts conversation with a first message me: replies userbot: "bleep blop I'm a bot" -> now the user has to accept me for pm.

Is this intended behaviour? Shouldn't a user be automatically accepted to PM if the userbot owner initiated the conversation?

baalajimaestro commented 5 years ago

Well, this is intended behaviour, and it was done cause it makes an unnecessary problem, when the person(the userbot) PMs, was blocked, and now unblocks and chats again, it will still stay approved, coz there is message history exists. I know this is annoying coz you get PM-ed and still replied as a non-approved.

I'll try my best to work this out in upcoming days :)

PaulSonOfLars commented 5 years ago

Thanks!

AvinashReddy3108 commented 5 years ago

A 'dirty' solution to this would be as follows

  1. PM the person you want to.
  2. Userbot asks whether to whitelist the person 2a. If yes, the the person is unblocked like @PaulSonOfLars wanted 2b. If not, then userbot blocks the person (like current/old behaviour)

Reason I proposed 2b is in use cases when you don't want replies from the person you sending messages to.

PaulSonOfLars commented 5 years ago

Why are you messaging people if you don't want replies from them? Seems like an odd, unhealthy edge case to be adding to a userbot used in a messaging platform...

I must admit that I don't quite see a situation where messaging someone does not implicitly give them the right to message you

baalajimaestro commented 5 years ago

@AvinashReddy3108 well, we were looking for an automatic approval, it must not intervene the pm if I was the one who started it.

We found out a haxx solution tho, it must theoretically work. Would work on implementing it once I finish up with the mongodb migration

baalajimaestro commented 5 years ago

Fixed under PR(#120)