search

RaphielGang / Telegram-Paperplane

The Paperplane userbot project - a Telegram userbot helping to improve your Telegram experience. https://t.me/tgpaperplane
Other
289 stars 1.06k forks source link

Fixed some DeepSource issues #258

Closed eliastheis closed 3 years ago

eliastheis commented 3 years ago

I found your repo in DeepSource and found a couple of issues to fix. This is my first pull request in an opensource project and I hope it is accepted. best regards Elias

zakaryan2004 commented 3 years ago

There is clearly something wrong with this. Fix your pull request. Have separate pull requests for each change.

eliastheis commented 3 years ago

@zakaryan2004 Do you know why there are 82 commits? If I look here, you see that there are only 3 commits from me. I am very confused.

zakaryan2004 commented 3 years ago

@zakaryan2004 Do you know why there are 82 commits? If I look here, you see that there are only 3 commits from me. I am very confused.

Pull requests don't work on the "commits by me" basis. That repo is based on a fork of Paperplane, which has many more commits, and you have done your changes on that fork, not the upstream ("original") Paperplane. Thus, when you do a pull request to the upstream Paperplane repo, GitHub adds all the new commits to the pull request. You should clone this repo and do your changes on it. Knowing some git and how GitHub works will help you.

zakaryan2004 commented 3 years ago

Also, we only accept pull requests to the staging branch.

eliastheis commented 3 years ago

So should I clone the staging branch and change my stuff there? And then do a pull request from there? Sorry for the extra work. I'm relatively new here and try to contribute to opensource projects.

zakaryan2004 commented 3 years ago

So should I clone the staging branch and change my stuff there? And then do a pull request from there? Sorry for the extra work. I'm relatively new here and try to contribute to opensource projects.

Yes.

raphielscape commented 3 years ago

Fixed in 230284e6d7ea6bac6976a5642a6c36883aa9c12b