Closed zoicware closed 4 months ago
Heya,
Thanks for taking the time to contribute 😄
As I said in #64 I am not a huge fan of force removing applications this way, as it does open the door to many issues if anything changes in the way these apps are installed.
I do feel like this approach is somewhat justified for edge, considering how nigh impossible it is to uninstall in most regions. However, I see little reason to force remove OneDrive like this as the current implementation via WinGet works quite well. Is there a specific reason to include Onedrive here too?
Heya,
Thanks for taking the time to contribute 😄
As I said in #64 I am not a huge fan of force removing applications this way, as it does open the door to many issues if anything changes in the way these apps are installed.
I do feel like this approach is somewhat justified for edge, considering how nigh impossible it is to uninstall in most regions. However, I see little reason to force remove OneDrive like this as the current implementation via WinGet works quite well. Is there a specific reason to include Onedrive here too?
yep, microsoft insist on further baking edge into the os. I included onedrive since if the user doesnt have or doesnt want winget installed the script sill functions as it should, I dont think it makes sense to do it that way when it can be done natively with powershell but ofc this is your script :)
Closing PR as feature has been implemented in 6049800
added two functions to remove edge and onedrive instead of trying to use winget works on 10 and 11 (latest)