Rapid-Design-of-Systems-Laboratory / beluga

General purpose indirect trajectory optimization
Other
25 stars 6 forks source link

Quantity substitution can fail if quantities are nested within quantities #181

Closed SeanMatthewNolan closed 5 years ago

SeanMatthewNolan commented 5 years ago

This is because each quantity is substituted sequentially. This seems to be able to be fixed by using a dictionary of quantities fed into the .subs method. Sympy appears to handle this automatically.

SeanMatthewNolan commented 5 years ago

My bad, this used to be an issue in an older version. When I checked the code it looked like it would still be for the way that it is written, but I guess I missed something because I cannot replicate what used to happen.