search

Rapougnac / VixBluesky

FixBluesky: Embed Bluesky links in Discord!
https://bskyx.app
GNU Affero General Public License v3.0
13 stars 1 forks source link

Add video embed support #6

Closed tuzonghua closed 3 days ago

tuzonghua commented 1 week ago

It's not officially official yet but Bluesky is adding video support. Example post (viewable on web or latest mobile app). bskyx should also embed the related video content.

Valac-Design commented 6 days ago

Bumping this, because my bot uses your url for embed routing, so we need to see some love for video.

yellingatmeVT commented 6 days ago

Bump because video is now a thing! Screenshots included to show (also I wish I knew your version for embeds sooner, much easier than typing out s/k/y all the time) Screenshot_20240911_200550_Bluesky Screenshot_20240911_201028_Discord

Rapougnac commented 5 days ago

Hi, I'm currently on vacation, I already started working on this, maybe I can release something by the end of the week, but no promises.

Rapougnac commented 4 days ago

Yaaay, it works!

image

The deployment is local only currently, since for now, I need to transcode the video into something readable by discord, which involves a backend and some cpu resources :/

Anyways, I'll push the changes as-is tomorrow if you guys are okay to use a slow version (~1.5-2s to generate the video from a cold (not cached) skeet).

FWIW, I'll continue digging to see if the transcoding is avoidable, but I have slender hopes :^)

Invertex commented 4 days ago

The deployment is local only currently, since for now, I need to transcode the video into something readable by discord, which involves a backend and some cpu resources :/

Just checking in case you just used the wrong term by accident, but if you're actually transcoding, you shouldn't need to do that. The streams appear to be H264-AVC encoded, so all that needs to be done for Discord to display them is to "remux" the streams into an mp4 container, which is a near instant operation compared to transcoding. But since you're saying only 1.5 to 2s I'm guessing you are remuxing, unless your server is pretty fast.

Thanks for getting on top of this so quick though! I was about to try doing it today myself lmao

Rapougnac commented 3 days ago

But since you're saying only 1.5 to 2s I'm guessing you are remuxing, unless your server is pretty fast.

What coding at 2:00 does to a mf :fire:

Yes, sorry for the mix of words, I managed to confuse myself while typing this.

Rapougnac commented 3 days ago

It's implemented, changes are now live :D

tuzonghua commented 3 days ago

@Rapougnac Video works! But it's not including the text in the embed. :( I can open it as a separate issue if that'll keep things clean.

Rapougnac commented 3 days ago

I know, I wanted to add a comment but completly forgor :sob:

I'd be happy if you open an issue, it'll not be my priority for now as I'm still in vacation and I need to get some fresh air. I should be back next week, if it's really annoying, PRs are open, it shouldn't be too complicated to implement.

Sorry, hope everyone will understand

Rapougnac commented 3 days ago

I can open it as a separate issue if that'll keep things clean.

Since #8 exists, it's not needed anymore, thank you for your awareness though.