search

Rapporter / pander

An R Pandoc Writer: Convert arbitrary R objects into markdown
http://rapporter.github.io/pander/
Open Software License 3.0
294 stars 65 forks source link

Support for ets class objects #231

Closed mitchelloharawild closed 8 years ago

mitchelloharawild commented 8 years ago

Added support for ets class objects

romantseg commented 8 years ago

Thanks for the PR! In general, great job, just few minor style comments (inlined). Also to fix the failing test, you need to abb forecast to recommented packages in DESCRIPTION.

mitchelloharawild commented 8 years ago

Thanks for the feedback, I've made some changes.

Checking output of tests, may have miscounted. Update: found issues and resolved them.

codecov-io commented 8 years ago

Current coverage is 77.61%

Merging #231 into master will increase coverage by +0.16% as of 54ce51f

Powered by Codecov. Updated on successful CI builds.

daroczig commented 8 years ago

@mitchelloharawild, thank you very much for the pull request & fixed, and thanks for @RomanTsegelskyi for the comments.

I generally like the output, but not sure if all parts are important -- can you please share your opinion on that? First, we return the call, which already includes the "type of ets" and "lambda" as well, so the next two lines seem to be redundant to me. Maybe we can have either the rather technical call or the other two lines, no? If we keep the call, was it intentional to have a line break between Call: and the formula? It will be rendered on the same line after calling pandoc -- as double line breaks are required in markdown for a new paragraph.

And maybe we could add a dollar sign around the sigma^2 and use LaTeX markup so that it renders much nicer in PDF/HTML/docx.

What do you think?

daroczig commented 8 years ago

As I did not hear from you about the above questions, I suppose everything is all right and should remain as is :) Thank you both, again! Merging.