search

Rapporter / pander

An R Pandoc Writer: Convert arbitrary R objects into markdown
http://rapporter.github.io/pander/
Open Software License 3.0
294 stars 65 forks source link

lint files #247

Closed romantseg closed 8 years ago

romantseg commented 8 years ago

I recently noticed that lintr was not working for pander (there is a small bug in lintr that can be avoided by slightly changing code). And when I was reviewing some PRs recently, I noticed that we haven't been very consistent with our style. This is an attempt to fix that. I will lint other files when I have time

daroczig commented 8 years ago

Please see above comment & failed Travis build -- but other than that, thank you very much for taking care of this, much appreciated!

daroczig commented 8 years ago

@RomanTsegelskyi any ideas on the Travis failure? I cannot reproduce that locally.

romantseg commented 8 years ago

Hmm, I was not able to reproduce it either. It might be change in knitr or other package, but I was not able to figure it out. I will probably get the VM to try to reproduce it in the exact environment.

romantseg commented 8 years ago

I was not even able to reproduce it on VM with Ubuntu 12.04 LTS. I am kind of out of ideas

daroczig commented 8 years ago

FTR I restarted the build yesterday on Travis to see if it was a temporary issue, but it failed with the same error message. Will try to find a way to debug this, but I don't have any ideas at the moment, either.

daroczig commented 8 years ago

@RomanTsegelskyi I disabled building the vignettes on the first build, which verified that this error comes from when doing hyphenation & we have some other failed tests as well at https://travis-ci.org/Rapporter/pander/builds/111564767

I will try to debug that hyphenation bug, but let me know if you have any further ideas.

daroczig commented 8 years ago

@RomanTsegelskyi good news on the strange error at https://github.com/travis-ci/travis-build/commit/f67c1010c9277a4607f31e514682fb29a82a9a7d#commitcomment-16611382 (it's fixed now)

Although the lint and GH page update parts still having some issues, but at least we are green again.

romantseg commented 8 years ago

Oh wow, thanks solving that. I will try to finish linting next week, after I come back to Seattle

daroczig commented 8 years ago

Thanks, @RomanTsegelskyi. I think the linting issue is now resolved after https://github.com/Rapporter/pander/commit/72c2f8983ea56e7d22b68ee036dc3df9cc7c3810

codecov-io commented 8 years ago

Current coverage is 76.58%

Merging #247 into master will decrease coverage by -0.01% as of cde2283

Powered by Codecov. Updated on successful CI builds.

romantseg commented 8 years ago

@daroczig, I finished linting and rebased it on master. Good to merge?

daroczig commented 8 years ago

Wow, thank you so much, @RomanTsegelskyi -- this looks awesome! I left a very important :) question on a strange space between two parens (L1139), but I think it's OK to merge -- please feel free to do so.