Rapporter / pander

An R Pandoc Writer: Convert arbitrary R objects into markdown
http://rapporter.github.io/pander/
Open Software License 3.0
294 stars 66 forks source link

Coming archiving on CRAN? #324

Closed elinw closed 6 years ago

elinw commented 6 years ago

Hi,

We got this notice today:

This concerns the CRAN packages

CONS DCM IAPWS95 MplusAutomation PCADSC QVM RSDA brr carpenter cleanEHR codebook dataMaid desctable docxtools eclust funModeling mscstexta4r mscsweblm4r packagefinder pander pubh rapport rapportools rmda skimr summarytools userfriendlyscience veccompare

maintained by one of you: <list of 23 packages>

We have repeatedly asked for an update fixing the check problems shown on https://cran.r-project.org/web/checks/check_results_pander.html with no reply from the maintainer thus far.

Thus, package pander is now scheduled for archival on 2018-07-19, and archiving this will necessitate also archiving its strong reverse dependencies.

Please negotiate the necessary actions.

Best

Can you tell us what is going on and if you intend to fix? Do you need help? For my package (skimr) we'd hate to lose pander support.

daroczig commented 6 years ago

Sorry for the trouble, I do have plans to fix this, but have been busy/traveling in the past months. To keep it short, I will fix this before the deadline.

MaximeWack commented 6 years ago

Hi, thank you for your answer!

A quick fix would be to remove the offending example, however all it does is hide the error.

A correct fix would be to change if (author != '') { to if (any(author != '')) { and if(title != '') { to if (any(title != '')) {

I'd also recommend sanitizing those character vector to remove empty strings prior to concatenation with paste0.

I've just added a PR with a fix here

daroczig commented 6 years ago

The failing example has been fixed and a new version will be soon pushed to CRAN.

daroczig commented 6 years ago

v0.6.2 has been submitted to CRAN, thanks all

ekstroem commented 6 years ago

Wonderful, thanks!