search

Rapporter / pander

An R Pandoc Writer: Convert arbitrary R objects into markdown
http://rapporter.github.io/pander/
Open Software License 3.0
294 stars 66 forks source link

Release on CRAN #347

Closed billdenney closed 2 years ago

billdenney commented 4 years ago

As discussed in #280, a new CRAN release would help. This issue will assist with the discussion around creating that new release.

@daroczig, to answer the question from the other issue, yes. I'll try to start some specific issue identification and make PRs (or help identify where changes are needed) to get there.

billdenney commented 4 years ago

I rapidly hit an error (I can't readily fix C++ issues):

c:/Rtools/mingw_64/bin/g++ -std=gnu++11 -shared -s -static-libgcc -o pander.dll tmp.def RcppExports.o helpers.o pandoc.o -LC:/PROGRA~1/R/R-36~1.3/bin/x64 -lR
   RcppExports.o:RcppExports.cpp:(.rdata+0x838): undefined reference to `pander_splitLine_cpp'
   RcppExports.o:RcppExports.cpp:(.rdata+0x850): undefined reference to `pander_tableExpand_cpp'
   collect2.exe: error: ld returned 1 exit status
   no DLL was created
   ERROR: compilation failed for package 'pander'

I got that when trying to run devtools::load_all() after cloning the repository. It appears to relate to how Rcpp::compileAttributes() works.

daroczig commented 4 years ago

Thanks a lot @billdenney :bow:

Unfortunately, this clearly shows that Windows has been always a bit neglected in this repo ... eg myself being a Linux user and (so thus) unit tests are only running on Linux as well -- but we should fix that latter.

Please let me know if you have time to look into adding appveyor support for Windows CI, otherwise I will take a look and also figure out the above issue.

Thanks again!

billdenney commented 4 years ago

@daroczig, I don't think that this is a Windows issue. The problem occurs with something about how Rcpp is rewriting source files. (Now, maybe that is Windows-specific in which case I'll take back my first sentence.)

daroczig commented 4 years ago

I've set up AppVeyor to be able to test this on Windows, and although there are quite some issues -- but the Rcpp build went fine: https://ci.appveyor.com/project/daroczig/pander

Meanwhile, Travis is misbehaving ... so cannot run the automated tests on Linux :sweat_smile:

I will try to get back to this soon, but no promises at the moment.

daroczig commented 2 years ago

was released on 2022-03-18

billdenney commented 2 years ago

Thanks!