Open hedsnz opened 1 year ago
Thanks a ton, this is indeed a great start!!
I think I can update the CDN (the rapporter.net service has been shut down a long time ago), but probably better to remove that functionality altogether.
I can take this from here, thanks again.
tools/update-jquery.R
yourself to verify that the source is correct). This method of updating dependencies is based on what Shiny currently does (e.g., https://github.com/rstudio/shiny/blob/main/tools/updatejQuery.R)Obviously there is no
jquery.min.js
in the Rapporter CDN currently, so the only way to reference the updated jQuery is, for example, by settingportable.html = FALSE
inPandoc.brew
. This is some example code from the README that I used to check:Note that the relevant code from
convert.R
is this, which uses local JavaScript source files instead of from the CDN:When
portable.html = TRUE
(default), the example gives several errors in the browser console (unable to access the CDN). When it's set to FALSE, there are fewer errors because it uses local versions, but there is one that may be related to the update of jQuery:This error points to line 84 in
custom.js
, which is this:The other side effect of this is that the page items load horizontally, instead of vertically. I'm guessing this is to do with the removal of slimbox but I'm not sure.
Sorry that I can't provide a fully functional patch, but hopefully this is a good start!
Thanks.