Rappsilber-Laboratory / build-xiview

GNU General Public License v3.0
2 stars 0 forks source link

Add support for assigning HEX/RGB values for user defined annotations upon upload #102

Closed mmsupermann closed 7 months ago

mmsupermann commented 7 months ago

This feature request would be great for consistency between coloring for journal submissions, as well as sticking with a defined color palette. Additionally, this would be especially useful for overlaying HDX-MS data onto the 2D crosslinking models. If there were a feature that allowed you to assign a HEX/RGB value in the 'color' column for user annotations instead of a text string, that would be very useful.

Please let me know if this could be added or if there is already a way I'm unaware of to assign colors to these values in the annotation file instead of the current text string (i.e., 'blue,' 'red,' 'yellow,' etc.).

Thanks!

Matt

colin-combe commented 7 months ago

hmmm, i thought it was like that (you could enter HEX/RGB), I'll check whats going on and get back to you, cheers, Colin

mmsupermann commented 7 months ago

I tried entering the HEX values or RGB but they always came up gray when I tried to apply them to the figure. Maybe I'm not inputting them correctly... Please let me know, thanks! -Matt

colin-combe commented 7 months ago

Hi Matt, for me this worked.

Could you share the CSV file you are uploading?

And maybe also a link to the dataset you're uploading it to, if that's OK? If you put the link to the data here in GH then you have essentially made your data public, you can email the link to me instead if you prefer: colin.combe@ed.ac.uk

cheers, Colin

mmsupermann commented 7 months ago

Hi Colin, I just tried it again, and realized I was neglecting to put the # before the color value, so it was returning all the annotations as gray. I'm sorry for misunderstanding how to do the uploads, but I'm glad this feature was added!

Looking forward to continuing to use XiView, and thank you again for helping me realize this was my own mistake.

Best Regards, Matt