search

Rappsilber-Laboratory / build-xiview

GNU General Public License v3.0
2 stars 0 forks source link

communictation with pdb down #109

Closed grandrea closed 2 months ago

grandrea commented 2 months ago

Hello, I tried to upload pdb via code today and got this error

pdb
colin-combe commented 2 months ago

mmtf.rcsb.org seems to be down

let's give it a bit to see if it comes back...

colin-combe commented 2 months ago

thanks for error report

colin-combe commented 2 months ago

ok... guess its not coming back https://www.rcsb.org/news/feature/663129f765d8a8cacaf76f9f

colin-combe commented 2 months ago

so i'm gonna have to fix this

colin-combe commented 2 months ago

its an NGL problem https://github.com/nglviewer/ngl/issues/1045

@grandrea - you remember this thing whereby i hacked NGL so that chainnames could be 2 characters instead of 1? (https://github.com/colin-combe/ngl/commit/71873ed45ee67cae5871235e59a4a49a43418cd6)

How important is that still? It did break some things in NGL, just not things we used much.

In other words, what if I just updated to most recent version of NGL (without the hack) to fix this? Do you think that would mess things up for people?

colin-combe commented 2 months ago

it should be that this is fixed in the latest version of NGL on npm (https://www.npmjs.com/package/ngl).

So i should be able to fix this in xiVIEW and tidy some stuff up by importing NGL straight from npm (which xiVIEW already uses for managing JS dependencies).

But then you lose that 2 char hack.

Awaiting your input.

grandrea commented 2 months ago

bye bye 2 char hack.

grandrea commented 2 months ago

(that work is done afaik)

colin-combe commented 2 months ago

So i should be able to fix this in xiVIEW and tidy some stuff up by importing NGL straight from npm

good that we have tests, because they now fail (after updating to most recent NGL).

Will look into what the problems are...

colin-combe commented 2 months ago

Things working again now?

grandrea commented 2 months ago

yes, all good