Rappsilber-Laboratory / build-xiview

GNU General Public License v3.0
2 stars 0 forks source link

Cannot concatenate 'str' and 'int' objects #63

Closed SarahJoergensen closed 2 years ago

SarahJoergensen commented 4 years ago

I exported my results from MeroX, but get the following error.

cannot concatenate 'str' and 'int' objects Screenshot_1 log id: or5ciab0qratqbbbrrupi816v1_1576403886.log

colin-combe commented 4 years ago

ok, thanks for report.

colin-combe commented 4 years ago

I think there is a problem with the CSV file you tried to upload.

Try opening it in a spreadsheet program - are there more columns of data than there are column headings?

If so, this is because there is a extra, not enclosed by quotes, comma in one of your data fields.

Look at it again in a speadsheet program - does it have the right thing in the 'rank' column?

SarahJoergensen commented 4 years ago

Hi Colin, Thank you for your help! You are right about the extra column of data compared to column headings. Is it a wrong type of .csv I am using? I have tried to save it as different .csv file types (comma-Delimited, Macintosh, and MS-DOS). When I use the MS-DOS I get this error instead. Best regards, Sarah

Den tir. 17. dec. 2019 kl. 16.34 skrev Colin notifications@github.com:

I think there is a problem with the CSV file you tried to upload.

Try opening it in a spreadsheet program - are there more columns of data than there are column headings?

If so, this is because there is a extra, not enclosed by quotes, comma in one of your data fields.

Look at it again in a speadsheet program - does it have the right thing in the 'rank' column?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Rappsilber-Laboratory/xiView_container/issues/63?email_source=notifications&email_token=AOBM2FCEG3LNW6XLK3ILURTQZDWQHA5CNFSM4J27IWBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHCYQJI#issuecomment-566593573, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOBM2FBS5BEBA675H7TGT7DQZDWQHANCNFSM4J27IWBA .

colin-combe commented 4 years ago

as far as I can tell, the problem is that your ScanId attributes contain commas, breaking the CSV file.

The ScanId also contains quote marks, complicating dealing with the comma by enclosing the whole ScanId with quotes.

I think it might work if the comma in ScanId is preceded by a backslash.

Is it a wrong type of .csv I am using?

I'm not sure where this file came from. If its direct output from MeroX then I would take this up with the MeroX team. If you've created it yourself, you have some fiddling around to do regarding escaping the comma.

The best thing would be if MeroX output mzIdentML, which is read by xiVIEW and is the standard for the data.

Even if you get the CSV files working, they are missing some of the information needed to provide you with annotated spectra. Specifically, the modification masses are missing, so you will need to enter these manually but they would have been included in the mzIdentML file.

colin-combe commented 4 years ago

on reflection, I'm maybe overstating it when I say "mzIdentML is the standard for the data". It is an existing, PSI endorsed standard but the crosslinking field has yet to reach consensus on what to use.

colin-combe commented 4 years ago

I think this could be closed because its a problem with your CSV?

Also, are you sure Merox doesn't export mzIdentML?