Rappsilber-Laboratory / xi-mzidentml-converter

Apache License 2.0
1 stars 1 forks source link

in python3 branch, use pyteomics.auxilliary.cvquery #25

Closed colin-combe closed 1 year ago

colin-combe commented 2 years ago

@lars-kolbowski - there is a function in pyteomics called pyteomics.auxilliary.cvquery which is a better version of our get_accessions function (https://pyteomics.readthedocs.io/en/latest/api/auxiliary.html)

there's a number of places where we've stored in db single accession numbers for cv terms where really i think we're going to need to store a number of accessions (mainly to do with modifications)

as I looked into this I realised our get_accessions function doesn't really work because sometimes the 'cvstr' is the key in the dictionary and sometimes it is the value.

I think this whole part of things can be tidied up using the pyteomics cvquery function.

i'm going to make a branch off the 'main' branch (so called coz it fixes the main function, there's a PR for it) to look at using this cvquery function