search

Rappsilber-Laboratory / xi-mzidentml-converter

Apache License 2.0
1 stars 1 forks source link

All additional search params #33

Closed colin-combe closed 1 year ago

colin-combe commented 1 year ago

store all additional search parameters rather than just ions, tests passing (also bug fix to links only csv parser)

colin-combe commented 1 year ago

I'm in favour of deleting stuff that's no longer necessary instead of commenting it out. We have the history

Yeah, i agree, i thought i might get that comment from you. In that case the stuff to do with ions i commented out can be removed - I'll do that

Did you check how this change affects the front-end prompt that asks the user to define the ions if they cannot be parsed?

No, but you're right there's an issue there... I'm mainly trying to move towards "parser/convertor for pride". I don't know how pride will deal with missing info on ions