Closed boehs closed 3 years ago
This is purposefully unsupported.
This is purposefully unsupported.
Just wondering... why?
It's bad UX. The reasons below are why I don't like auto-removal (not in this PR) and ignoring reaction removal (which is basically the same thing)
Ultimately the current code offers a consistent UX -- 1 click or tap and the button works. With the PR then this stuff will always take two clicks (bad UX) and if there's auto removal in the user code somewhere then there's going to be an extra HTTP request that might work or not leading it to require 2 clicks for the user anyway.
I'm just not a fan and would rather not offer library users a footgun like this.
I'm just not a fan and would rather not offer library users a footgun like this.
While I agree that the two click is probably better in most cases, I am a firm believer in the power of choice. in this case, it defaults to accepting both removal and addition, so all it really does is give users the choice of if they wish to utilize this feature, and unless they explicitly want it, it will default to the "better" way.
What's wrong with choice?
Adding the choice gives the implication that the library is okay with the footgun, when it isn't. I don't want library users to get banned for removing reactions and I don't want other menu consumers to suffer from poor UX. I also don't want to maintain a potential race condition when someone inevitably decides to delete a reaction and they forgot to toggle on this setting. Removing my comment in the PR kind of makes it seem like the race isn't there when I've warned about it well in advance.
Adding the choice gives the implication that the library is okay with the footgun, when it isn't. I don't want library users to get banned for removing reactions and I don't want other menu consumers to suffer from poor UX. I also don't want to maintain a potential race condition when someone inevitably decides to delete a reaction and they forgot to toggle on this setting. Removing my comment in the PR kind of makes it seem like the race isn't there when I've warned about it well in advance.
I could reinstate the comment 👀 . what you said about banning is interesting though, at worst wouldn't a rate limit be applied?
Hey 👋🏻 , this is my first ever code change to a repository I don't manage so chances are I probably did something wrong here, and that there is a better way to do so. If you know a better way feel free to suggest!