Server vs Guild - Githubissues

Rapptz commented 8 years ago

At the moment the API wrapper calls what the API internally calls "guilds" as "servers" due to the UI association with a "guild" being called a server. This is a left over from the library being written as a reverse engineer attempt from the beginning.

Should Server and all instances of server be renamed to Guild and guild respectively to be more consistent with the API terminology?

You cannot have both naming schemes and I'm only going to count votes from this issue.

Fuyukai commented 8 years ago

I vote Guild as it's consistent with API terminology

devsnek commented 8 years ago

i think that guilds makes sense because it's how the official refers to it.

Martmists-GH commented 8 years ago

I vote server because I don't think we should fix something that isn't broken

byronvanstien commented 8 years ago

I'd go for Guild because it'd match how the API refers to it

Helehelehele commented 8 years ago

Guild, thanks.

Phxntxm commented 8 years ago

I vote for Guild, keep the library consistent with how Discord itself calls it.

Twentysix26 commented 8 years ago

As much as I dislike the word, guild for consistency with the API

2b7q8 commented 8 years ago

Guild.

Maverun commented 8 years ago

Guild it is gonna be biggest break change for covert server object to guild lol

NotSoSuper commented 8 years ago

Server, this will be the biggest search and replace I'd have to do if renamed...

Helehelehele commented 8 years ago

@NotSoSuper It's for a rewrite, you'll have to rewrite most of your code anyways.

ccubed commented 8 years ago

As much as I hate the Guild structure, a wrapper should mirror what it abstracts. So Guild here too.

ghost commented 8 years ago

guild and server

NotSoSuper commented 8 years ago

@Helehelehele how so? Afaik he's only changing the server class name to guild.

jayktaylor commented 8 years ago

@NotSoSuper The entire lib is going through a rewrite

Helehelehele commented 8 years ago

@NotSoSuper see https://github.com/Rapptz/discord.py/milestone/5

NotSoSuper commented 8 years ago

thanks, was unaware of that.

PapyrusThePlant commented 8 years ago

I'm team 'server'.

As evoked in discord, the permissions have different names too, "Manage Server" vs "Manage Guild", etc. As much as being consistent with the api is nice, being consistent with the UI and what people are used to see feels more right.

Only people that are used to discord's docs might get confused, others will look at this lib's docs and never even know they have a different name.

If you go the "api consistency" way, I can already feel the "how do I check if someone has the manage server permission???" coming.

daveter9 commented 8 years ago

I'd go with Guild as well.

Helehelehele commented 8 years ago

@PapyrusThePlant you can't cure ignorance. People get into d.py channel without knowing any programming languages. They are the ones who need to adapt, not the lib.

abalabahaha commented 8 years ago

Guild would be nice

Pierce01 commented 8 years ago

I'm going with Server. I agree with Papyrus.

james9837 commented 8 years ago

My 2 cents even though I just started... 'Server'

it works as-is
API is inconsistent with UI anyway and the guild<->server mapping is even noted in the developer docs @ https://discordapp.com/developers/docs/resources/guild as: Guilds in Discord represent a collection of users and channels into an isolated "server".
Add in the comments for relevant items something along the lines of "Note: the discord api refers to servers as guilds"

In the end, it doesn't really matter all that much. IF the decision is made to go with 'guild' then I'd suggest the reverse of the item above... "Note: the discord UI refers to guilds as servers"

RossSmyth commented 8 years ago

I vote Guild for consistency :smile:

SapphicCode commented 8 years ago

I'd have to vote Guild too, as it's what the documentation and actual CSS use. I dislike the use of the word internally as I feel they're still servers, but feel it makes more sense from the official API point of view.

ghost commented 8 years ago

+1 for Guild from me

ngbeslhang commented 8 years ago

Following the majority.

edwanvi commented 8 years ago

Screw it. Guild.

Also, I made a strawpoll in case anyone wants to use it.

amishshah commented 8 years ago

If it's not too late, discord.js switched from Server to Guild between version 8 and 9

abalabahaha commented 8 years ago

discord.py isn't discord.js

amishshah commented 8 years ago

Abal I know but I thought it might help Danny as most of our users didn't care too much that it changed, he may choose to leave it the same for the sake of backwards compatibility but I believe he might as well change it now

ghost commented 8 years ago

abal stop

amishshah commented 8 years ago

Sorry hope my further comment cleared it up

Rapptz commented 8 years ago

I already changed it to guild in the rewrite I have locally.

Rapptz / discord.py

Server vs Guild #302