search

Raptacon / Robot-2020

MIT License
3 stars 3 forks source link

Spark Max Fixes #91

Closed ManiacMoustache closed 4 years ago

ManiacMoustache commented 4 years ago

Spark maxs are fiddly. No idea how we fixed them. We need to figure these things out.

ChrisHirsch commented 4 years ago

This PR seems to crash the sim: File ".\robot.py", line 121, in instantiateSubsystemGroup items = {key:factory(descp) for (key, descp) in config.getGroupDict(subsystem, groupName).items()} File ".\robot.py", line 121, in items = {key:factory(descp) for (key, descp) in config.getGroupDict(subsystem, groupName).items()} File "Y:\Users\chirsch\src\raptacon\Robot-2020\utils\motorHelper.py", line 38, in createMotor setTalonFXCurrentLimits(motor, motorDescp) File "Y:\Users\chirsch\src\raptacon\Robot-2020\utils\motorHelper.py", line 80, in setTalonFXCurrentLimits triggerThresholdCurrent = currentLimits['triggerThresholdCurrent'] KeyError: 'triggerThresholdCurrent'

ChrisHirsch commented 4 years ago

This PR seems to crash the sim: File ".\robot.py", line 121, in instantiateSubsystemGroup items = {key:factory(descp) for (key, descp) in config.getGroupDict(subsystem, groupName).items()} File ".\robot.py", line 121, in items = {key:factory(descp) for (key, descp) in config.getGroupDict(subsystem, groupName).items()} File "Y:\Users\chirsch\src\raptacon\Robot-2020\utils\motorHelper.py", line 38, in createMotor setTalonFXCurrentLimits(motor, motorDescp) File "Y:\Users\chirsch\src\raptacon\Robot-2020\utils\motorHelper.py", line 80, in setTalonFXCurrentLimits triggerThresholdCurrent = currentLimits['triggerThresholdCurrent'] KeyError: 'triggerThresholdCurrent'

This actually wasn't a probem with this PR. It was already in Master and has been fixed