search

Raptor007 / aq2-tng

Action Quake 2: The Next Generation. Raptor007's sandbox for testing changes. When verified stable, this code is pushed to the official aq2-tng repo:
https://github.com/aq2-tng/aq2-tng/tree/bots
4 stars 2 forks source link

Sync from aqtion to Raptor master #134

Closed darkshade9 closed 2 years ago

darkshade9 commented 2 years ago

I've painstakingly removed what was not meant for the master branch and left in some changes that Reki had for the antilag stuff. Added in is some VSCode stuff for building in MSVC and some very minor changes.

Raptor007 commented 2 years ago

Thank you! I know that can be a pain. Looking at Files changed I'm not seeing any major concerns.

It looks like you've got a slightly older copy of p_antilag.c before this commit. If you compare that to Files changed you can see what I mean. There's no functional difference, but I'd moved the variable declarations to the beginning of their scope to match the rest of the Q2 codebase and improve compatibility with older compilers. It would be a bit cleaner if you could grab my latest p_antilag.c and commit it to your master. Or I could just redo those changes after merging this.

I might be wrong about this, but it appears the Visual Studio project may have globally renamed to gamex86_64 rather than just doing it for the x64 targets. This won't affect those of us using MinGW to build on Windows, but you might want to double-check that if you're using VS to make both 32-bit and 64-bit builds.

darkshade9 commented 2 years ago

I grabbed the latest version of p_antilag.c from master. I don't have VS to properly format the proj files (probably wouldn't know what I was changing even if I did :) ), I can remove those from the PR.